Skip to content

Update doc to use "term" instead of "terminal" #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update doc to use "term" instead of "terminal" #2

wants to merge 1 commit into from

Conversation

arp242
Copy link
Contributor

@arp242 arp242 commented Dec 10, 2020

Very small patch, but the example at the top still used the old
"terminal" package name, resulting in "golang.org/x/crypto/ssh/terminal"
being goimport'd instead of golang.org/x/term

@arp242
Update doc to use "term" instead of "terminal"
594c1a0 
Very small patch, but the example at the top still used the old
"terminal" package name, resulting in "golang.org/x/crypto/ssh/terminal"
being goimport'd instead of golang.org/x/term
@google-cla google-cla bot added the cla: yes label Dec 10, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 594c1a0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/term/+/276912 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Daniel Martí:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/276912.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=5067968a

Please don’t reply on this GitHub thread. Visit golang.org/cl/276912.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/276912.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1: Code-Review+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/276912.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 10, 2020
@arp242 @mvdan
Update doc to use "term" instead of "terminal"
2321bbc 
Very small patch, but the example at the top still used the old
"terminal" package name, resulting in "golang.org/x/crypto/ssh/terminal"
being goimport'd instead of golang.org/x/term

Change-Id: If02a2d7ef6fe63fa86f98ca16b523d06ad897474
GitHub-Last-Rev: 594c1a0
GitHub-Pull-Request: #2
Reviewed-on: https://go-review.googlesource.com/c/term/+/276912
Reviewed-by: Daniel Martí <[email protected]>
Reviewed-by: Bryan C. Mills <[email protected]>
Trust: Daniel Martí <[email protected]>
Trust: Bryan C. Mills <[email protected]>
Run-TryBot: Daniel Martí <[email protected]>
TryBot-Result: Go Bot <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/276912 has been merged.

@gopherbot gopherbot closed this Dec 10, 2020
ldemailly added a commit to ldemailly/term that referenced this pull request Aug 8, 2024
@ldemailly
prep for release under fortio.org/term (golang#2)
113a4d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arp242 @gopherbot